This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 09/14] Remove some cleanups from location.c


On 2017-04-08 16:12, Tom Tromey wrote:
This removes some more cleanups from location.c by using
unique_xmalloc_ptr.

I was going to ask if you considered using std::string, but when I tried it I realized the explicit_location class was not ready to receive std::strings yet. When we get there, I think the string_to_explicit_location will gain a lot in readability. So given the circumstances, this patch looks good to me.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]