This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA v2 16/17] Add a constructor and destructor to linespec_result

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Wed, 12 Apr 2017 08:30:22 -0600
Subject: Re: [RFA v2 16/17] Add a constructor and destructor to linespec_result
Authentication-results: sourceware.org; auth=none
References: <20170411150112.23207-1-tom@tromey.com> <20170411150112.23207-17-tom@tromey.com> <a28c19ad2c985a2f77b93cf8b57e4727@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> On 2017-04-11 11:01, Tom Tromey wrote:
>> linespec_result is only ever allocated on the stack, so it's
>> relatively easy to convert to having a constructor and a destructor.
>> This patch makes this change.  This removes some cleanups.

Simon> LGTM, though there are still some references in comments to
Simon> destroy_linespec_result that could be cleaned up.

I've changed these to refer to the linespec_result destructor instead.

Tom

References:
- [RFA v2 00/17] miscellaneous C++-ification
  - From: Tom Tromey
- [RFA v2 16/17] Add a constructor and destructor to linespec_result
  - From: Tom Tromey
- Re: [RFA v2 16/17] Add a constructor and destructor to linespec_result
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]