This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA v2 06/17] Remove cleanup_iconv

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Wed, 12 Apr 2017 08:32:49 -0600
Subject: Re: [RFA v2 06/17] Remove cleanup_iconv
Authentication-results: sourceware.org; auth=none
References: <20170411150112.23207-1-tom@tromey.com> <20170411150112.23207-7-tom@tromey.com> <4dc59bfe-8129-03c6-4e47-0c246986f388@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> I find the inversion of the order of "from" and "to" potentially
Pedro> confusing/misleading, given this is a "wrapper" class.  Is there a
Pedro> rationale behind the swap?

It mirrors the call to convert_between_encodings, but I agree with your
critique, so I've changed it.

Tom

References:
- [RFA v2 00/17] miscellaneous C++-ification
  - From: Tom Tromey
- [RFA v2 06/17] Remove cleanup_iconv
  - From: Tom Tromey
- Re: [RFA v2 06/17] Remove cleanup_iconv
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]