This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/9] Remove addr_size field from struct piece_closure

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>, gdb-patches at sourceware dot org
Date: Thu, 13 Apr 2017 23:38:20 -0400
Subject: Re: [PATCH 4/9] Remove addr_size field from struct piece_closure
Authentication-results: sourceware.org; auth=none
References: <1491586736-21296-1-git-send-email-arnez@linux.vnet.ibm.com> <1491586736-21296-5-git-send-email-arnez@linux.vnet.ibm.com> <86inm8ad1y.fsf@gmail.com>

On 2017-04-13 05:10, Yao Qi wrote:

Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
The addr_size field in the piece_closure data structure is a relicfrombefore introducing the typed DWARF stack. It is obsolete now. Thispatch
removes it.

gdb/ChangeLog:

	* dwarf2loc.c (struct piece_closure) <addr_size>: Remove field.
	(allocate_piece_closure): Drop addr_size parameter.
	(dwarf2_evaluate_loc_desc_full): Adjust call to
	allocate_piece_closure.
LGTM.

Since you are planning on making a v2, I think it's better if you checkit in right now to get it out of the way (it could be obvious anyway).


Simon

Follow-Ups:
- Re: [PATCH 4/9] Remove addr_size field from struct piece_closure
  - From: Andreas Arnez

References:
- [PATCH 0/9] Various DWARF piece fixes
  - From: Andreas Arnez
- [PATCH 4/9] Remove addr_size field from struct piece_closure
  - From: Andreas Arnez
- Re: [PATCH 4/9] Remove addr_size field from struct piece_closure
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]