This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 8/8] Python: Introduce gdb.Instruction class

From: Eli Zaretskii <eliz at gnu dot org>
To: Tim Wiederhake <tim dot wiederhake at intel dot com>
Cc: gdb-patches at sourceware dot org, markus dot t dot metzger at intel dot com, brobecker at adacore dot com, qiyaoltc at gmail dot com
Date: Fri, 21 Apr 2017 15:20:07 +0300
Subject: Re: [PATCH v2 8/8] Python: Introduce gdb.Instruction class
Authentication-results: sourceware.org; auth=none
References: <1492771786-26372-1-git-send-email-tim.wiederhake@intel.com> <1492771786-26372-9-git-send-email-tim.wiederhake@intel.com>
Reply-to: Eli Zaretskii <eliz at gnu dot org>

> From: Tim Wiederhake <tim.wiederhake@intel.com>
> Cc: markus.t.metzger@intel.com, brobecker@adacore.com, qiyaoltc@gmail.com
> Date: Fri, 21 Apr 2017 12:49:46 +0200
> 
> +@defvar RecordInstruction.number
> +An integer identifying this instruction.  @var{number} corresponds to

@var is wrong here; please use @code instead.  (Yes, I know it was
that way in theoriginal text.)

Otherwise, the documentation part is approved.

Thanks.

Follow-Ups:
- RE: [PATCH v2 8/8] Python: Introduce gdb.Instruction class
  - From: Wiederhake, Tim

References:
- [PATCH v2 0/8] Python bindings for GDB record
  - From: Tim Wiederhake
- [PATCH v2 8/8] Python: Introduce gdb.Instruction class
  - From: Tim Wiederhake

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]