This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch+8.0] release branch: Fix: --enable-werror
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Joel Brobecker <brobecker at adacore dot com>
- Date: Sat, 22 Apr 2017 12:20:06 -0400
- Subject: Re: [patch+8.0] release branch: Fix: --enable-werror
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8076116181
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8076116181
- References: <20170421085204.GA5501@host1.jankratochvil.net>
On Friday, April 21 2017, Jan Kratochvil wrote:
> Hi,
>
> gdb-8.0-branch
> ./configure --enable-werror --enable-targets=all
> aarch64-tdep.c:3045:13: error: ‘void selftests::aarch64_process_record_test()’ declared ‘static’ but never defined [-Werror=unused-function]
> arm-tdep.c:9601:13: error: ‘void selftests::arm_record_test()’ declared ‘static’ but never defined [-Werror=unused-function]
>
> OK for check-in?
>
> Please do not tell me release branches do not support --enable-werror as this
> is due to a sourcebase bug, not due to some unexpected compiler
> incompatibility.
>
> Sergio: Shouldn't it be also buildbot-tested?
Yes, it should. We have an Arch64 builder managed by Yao. It should
be possible to set up builders for the 8.0 branch.
> Jan
>
> gdb/ChangeLog
> 2017-04-21 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * aarch64-tdep.c (selftests::aarch64_process_record_test): Make it #if
> GDB_SELF_TEST.
> * arm-tdep.c (selftests::arm_record_test): Likewise.
>
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 28c2573..6113621 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -3040,10 +3040,12 @@ aarch64_dump_tdep (struct gdbarch *gdbarch, struct ui_file *file)
> paddress (gdbarch, tdep->lowest_pc));
> }
>
> +#if GDB_SELF_TEST
> namespace selftests
> {
> static void aarch64_process_record_test (void);
> }
> +#endif
>
> /* Suppress warning from -Wmissing-prototypes. */
> extern initialize_file_ftype _initialize_aarch64_tdep;
> diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
> index c8fabfb..9ac667f 100644
> --- a/gdb/arm-tdep.c
> +++ b/gdb/arm-tdep.c
> @@ -9596,10 +9596,12 @@ arm_dump_tdep (struct gdbarch *gdbarch, struct ui_file *file)
> (unsigned long) tdep->lowest_pc);
> }
>
> +#if GDB_SELF_TEST
> namespace selftests
> {
> static void arm_record_test (void);
> }
> +#endif
>
> extern initialize_file_ftype _initialize_arm_tdep; /* -Wmissing-prototypes */
>
>
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/