This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Out-of-date lm_info in nto-tdep.c
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Aleksandar Ristovski <aristovski at qnx dot com>, gdb-patches at sourceware dot org
- Date: Sun, 23 Apr 2017 23:36:13 -0400
- Subject: Out-of-date lm_info in nto-tdep.c
- Authentication-results: sourceware.org; auth=none
Hi Aleksandar,
I am writing to you because you most recently update the Neutrino port
of GDB.
I am in the process of reworking the lm_info structures, and noticed
that nto-tdep.c has its own copy of the lm_info structure found in
solib-svr4.c. However, it appears to have been out-of-date for quite
some time. Commit 3957565 [1] changed the layout of svr4's lm_info in
2011 and the version in nto-tdep.c hasn't been updated. This probably
means that nto's lm_addr function is broken. Could you check how that
affects the nto target and if something needs fixing?
If it can help you, I am planning to make lm_info an empty base class,
from which the various implementations will inherit (e.g. lm_info_svr4,
lm_info_darwin, etc). This means that we could put the svr4-specific
structure, lm_info_svr4, in the header file solib-svr4.h. The structure
would then be available for nto-tdep.c to use, so it wouldn't need to
have its own copy.
Thanks,
Simon
[1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=3957565