This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Make sure malloc is linked into gdb.cp/oranking.cc.
- From: Keith Seitz <keiths at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 2 May 2017 11:42:58 -0700
- Subject: [PATCH] Make sure malloc is linked into gdb.cp/oranking.cc.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=keiths at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E0E7B716E3
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E0E7B716E3
On some platforms, e.g., arm-eabi-none, we need to make certain that
malloc is linked into the program because oranking.exp uses function
calls requiring it:
(gdb) p foo101("abc")
evaluation of this expression requires the program to have a function "malloc".
While not a big deal (this is /not/ a regression), I think this would be
appropriate for inclusion in 8.0.
gdb/testsuite/ChangeLog
* gdb.cp/oranking.cc (dummy): New function to grab malloc.
(main): Call it.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.cp/oranking.cc | 17 +++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 9c0d68b..2e587d6 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2017-05-02 Keith Seitz <keiths@redhat.com>
+
+ * gdb.cp/oranking.cc (dummy): New function to grab malloc.
+ (main): Call it.
+
2017-05-01 Tim Wiederhake <tim.wiederhake@intel.com>
* gdb.python/py-record-btrace.exp: Rename prev_sibling and next_sibling
diff --git a/gdb/testsuite/gdb.cp/oranking.cc b/gdb/testsuite/gdb.cp/oranking.cc
index bd2f51b..1357610 100644
--- a/gdb/testsuite/gdb.cp/oranking.cc
+++ b/gdb/testsuite/gdb.cp/oranking.cc
@@ -1,3 +1,18 @@
+#include <cstdlib>
+
+/* Make sure `malloc' is linked into the program. If we don't, tests
+ in the accompanying expect file may fail:
+
+ evaluation of this expression requires the program to have a function
+ "malloc". */
+
+void
+dummy ()
+{
+ void *p = malloc (16);
+
+ free (p);
+}
/* 1. A standard covnersion sequence is better than a user-defined sequence
which is better than an elipses conversion sequence. */
@@ -165,6 +180,8 @@ test15 ()
}
int main() {
+ dummy ();
+
B b;
foo0(b);
foo1(b);
--
2.1.0