This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Stafford Horne <shorne at gmail dot com>
- Cc: GDB patches <gdb-patches at sourceware dot org>, Openrisc <openrisc at lists dot librecores dot org>, Franck Jullien <franck dot jullien at gmail dot com>
- Date: Tue, 09 May 2017 14:54:01 +0100
- Subject: Re: [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
- Authentication-results: sourceware.org; auth=none
- References: <cover.1493038197.git.shorne@gmail.com> <cover.1493038197.git.shorne@gmail.com> <dbd35ae7e8f9ca8db89dd14b81119d3eb50afb98.1493038197.git.shorne@gmail.com> <86r307725n.fsf@gmail.com> <20170502154115.GH2724@lianli.shorne-pla.net>
Stafford Horne <shorne@gmail.com> writes:
> This change is to also allow returning true in the case that the register
> group was registered with gdb with reggroup_add(). This seems like
> something that will be generally required so it was added to the
> target-descriptions definition. If you think not I can make it for
> openrisc only, but I think it makes more sense in tdesc.
Thanks for the explanation.
>
> This allows the command like, the below to return the registers for the
> named reggroup.
>
> info reg system
Some bits are missing,
- A test case, in which we can define some reggroups "foo" and test
expected "foo" is shown in the output of "maintenance print
reggroups". You can add reggroups in gdb.xml/extra-regs.xml.
- A test case with live inferior, get a list of support reggroups from
the output of "maint print reggroups", pass each reggroup to "info
reg $group", and test there is no error.
- Document "info registers".
https://sourceware.org/gdb/current/onlinedocs/gdb/Registers.html
doesn't document the usage "info reg GROUP". We need to add it.
- Add a news entry, because your patch adds a user visible change.
--
Yao (齐尧)