This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 09/12] btrace: Remove struct btrace_thread_info::flow.


On 2017-05-10 07:46, Wiederhake, Tim wrote:
The patch LGTM, but I have one question.  Did you consider adding a
backlink in btrace_function to its btrace_thread_info owner?  It would
possible to implement gap->next () and gap->prev (), which could be used
in many places, and would probably be more readable than

   ftrace_find_call_by_number (btinfo, gap->number - 1)
   ftrace_find_call_by_number (btinfo, gap->number + 1)

And it could possibly bring more simplifications, I didn't look in
details.

I believe, a C++-ificiation patch series could get rid of
call_iterator and insn_iterator altogether. Sorry if I sound like a
broken record :).

No worries, I see no problem in addressing that in a later series.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]