This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Use watchpoint's language when re-parsing expression
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>, Tom Tromey <tom at tromey dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, gdb-patches at sourceware dot org
- Date: Fri, 19 May 2017 15:32:34 +0100
- Subject: Re: [RFA] Use watchpoint's language when re-parsing expression
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6B5AE81245
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6B5AE81245
- References: <20170518023916.19913-1-tom@tromey.com> <mvminky1up8.fsf@suse.de> <8760gxc07m.fsf@pokyo> <20170519135113.agxaih5pcdeew3co@adacore.com>
On 05/19/2017 02:51 PM, Joel Brobecker wrote:
>> Andreas> The docs say that gdb is supposed to support C style casts in every
>> Andreas> language. Also, there is the {type} operator that is also supported in
>> Andreas> every language.
> [...]
>> Finally, I'm not at all certain that C-style casts or the {type}
>> operator can be added to the Rust expression parser without breaking
>> something else. And, that seems like a complex request just to unbreak
>> what amount to an implementation detail.
>
> FWIW, I also never noticed this, and I share the concerns about
> making this a requirement for all languages. It really depends
> on the language itself whether it's easy to implement such feature,
> and I would hate for language parsers to be harder to maintain
> just so we can provide a bit of a C-centric view to every language
> we support.
>
> I vote for downgrading the requirement and amending the documentation
> instead.
>
I agree. The patch LGTM.
Thanks,
Pedro Alves