RE: [PATCH v6 00/12] btrace: Turn linked list of function call segments into vector

["Wiederhake, Tim" <tim dot wiederhake at intel dot com>]

Hi all,

Ping.

Regards,
Tim

> -----Original Message-----
> From: Wiederhake, Tim
> Sent: Wednesday, May 17, 2017 9:57 AM
> To: gdb-patches@sourceware.org
> Cc: Metzger, Markus T <markus.t.metzger@intel.com>;
> simon.marchi@polymtl.ca
> Subject: [PATCH v6 00/12] btrace: Turn linked list of function call
> segments into vector
> 
> Hi all,
> 
> this series removes the extra list of btrace function call segments in
> struct
> btrace_thread_info.  To achieve this, the doubly linked list of function
> call
> segments in struct btrace_thread_info is replaced by a std::vector.
> 
> V1 of this series can be found here:
> https://sourceware.org/ml/gdb-patches/2017-02/msg00482.html
> 
> V2 of this series can be found here:
> https://sourceware.org/ml/gdb-patches/2017-05/msg00168.html
> 
> V3 of this series can be found here:
> https://sourceware.org/ml/gdb-patches/2017-05/msg00202.html
> 
> V4 of this series can be found here:
> https://sourceware.org/ml/gdb-patches/2017-05/msg00252.html
> 
> V5 of this series can be found here:
> https://sourceware.org/ml/gdb-patches/2017-05/msg00284.html
> 
> Changes since V5:
> * Changed comment in ftrace_new_function.
> * Initialized fields in btrace_function directly.
> * Put comment on btrace_thread_info::functions in a different patch.
> * Replaced manual segment number <-> index calculation in record-btrace.c
> * Reworked length check in ftrace_compute_global_level_offset.
> 
> V4 was ACK'd by Simon except for patch #12, which is addressed in V5 and
> V6.
> 
> The patches up to and including patch #6, "btrace: Remove constant
> arguments",
> are unchanged since V4.
> 
> Regards,
> Tim
> 
> Tim Wiederhake (12):
>   btrace: Use std::vector in struct btrace_thread_information.
>   btrace: Transfer ownership of pointers.
>   btrace: Add btinfo to instruction interator.
>   btrace: Use function segment index in call iterator.
>   btrace: Use function segment index in insn iterator.
>   btrace: Remove constant arguments.
>   btrace: Remove struct btrace_thread_info::{begin,end}.
>   btrace: Replace struct btrace_function::up.
>   btrace: Remove struct btrace_function::flow.
>   btrace: Replace struct btrace_function::segment.
>   btrace: Remove bfun_s vector.
>   btrace: Store function segments as objects.
> 
>  gdb/btrace.c                  | 852 +++++++++++++++++++++----------------
> -----
>  gdb/btrace.h                  |  77 ++--
>  gdb/python/py-record-btrace.c |  12 +-
>  gdb/record-btrace.c           |  41 +-
>  4 files changed, 485 insertions(+), 497 deletions(-)
> 
> --
> 2.7.4

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928