This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[ping] [PATCH v2 00/19] Various DWARF piece fixes


Ping:

  https://sourceware.org/ml/gdb-patches/2017-05/msg00215.html

ON Tue, May 09 2017, Andreas Arnez wrote:

> This series fixes various issues with DWARF piece handling.
> Specifically it almost rewrites the functions read_pieced_value and
> write_pieced_value in multiple steps.  Test cases are added as well.

So far I've received feedback from Yao, and for v1 also from Simon.
Thanks again for that!  Now, if I tracked correctly, the patches
check-marked with [X] are approved:

- [X] Add test for modifiable DWARF locations
- [X] write_pieced_value: Fix size capping logic
- [X] PR gdb/21226: Take DWARF stack value pieces from LSB end
- [X] Remove addr_size field from struct piece_closure
- [X] gdb/testsuite: Add "get_endianness" convenience proc
- [X] read/write_pieced_value: Respect value parent's offset
- [X] write_pieced_value: Fix copy/paste error in size calculation
- [X] write_pieced_value: Include transfer size in byte-wise check
- [X] write_pieced_value: Fix buffer offset for memory pieces
- [X] write_pieced_value: Transfer least significant bits into bit-field
- [X] Add DWARF piece test cases for bit-field access
- [X] read/write_pieced_value: Drop 'buffer_size' variable
- [ ] Fix handling of DWARF register pieces on big-endian targets
- [ ] read/write_pieced_value: Improve logic for buffer allocation
- [X] Respect piece offset for DW_OP_bit_piece
- [ ] read/write_pieced_value: Remove unnecessary variable copies
- [ ] Fix bit-/byte-offset mismatch in parameter to read_value_memory
- [X] write_pieced_value: Notify memory_changed observers
- [ ] read/write_pieced_value: Merge into one function

For the 5 non-check-marked patches I haven't received feedback yet.

--
Andreas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]