This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 16/23] Remove in_user_command
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 5 Jun 2017 14:27:30 +0100
- Subject: Re: [RFA 16/23] Remove in_user_command
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9E7DCC0587E1
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9E7DCC0587E1
- References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-17-tom@tromey.com>
On 05/03/2017 11:46 PM, Tom Tromey wrote:
> While working on the next patch in this series, I found that the
> global in_user_command is not used.
Looks like I removed the last (or only) user in:
268a799a454ce862f516ff2215290fae08eca7fa ("Make stdin be per UI")
https://sourceware.org/ml/gdb-patches/2016-05/msg00123.html
> This patch removes it. (I didn't
> think to check Insight until submitting this series; and it's not very
> convenient to do so, so if someone has it checked out and could look
> at it, that would be nice.)
Insight master is still based on a gdb from Jan 2016 so it still
has the use in the old input_from_terminal_p in top.c, but there's no
use in gdbtk/libgui. If insight really needs it when it rebases,
we can come up with something then.
>
> 2017-05-02 Tom Tromey <tom@tromey.com>
>
> * top.h (in_user_command): Remove.
> * top.c (in_user_command): Remove.
> * cli/cli-script.c (do_restore_user_call_depth)
> (execute_user_command): Update.
OK.
Thanks,
Pedro Alves