This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/11] Add IA64_MAX_REGISTER_SIZE
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Tue, 6 Jun 2017 12:57:16 +0000
- Subject: Re: [PATCH 2/11] Add IA64_MAX_REGISTER_SIZE
- Authentication-results: sourceware.org; auth=none
- Authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <B65C3EF7-3E91-4044-83A1-DD681C5422DF@arm.com> <8637dnqils.fsf@gmail.com> <90F5717F-8685-4C74-B2E4-7317AF228034@arm.com> <86pogivp7m.fsf@gmail.com> <0CAAE3E4-1860-40FF-895E-6C6A54A4EAB6@arm.com> <86vapsqxld.fsf@gmail.com> <498D342A-2994-4664-968D-F97A80C66059@arm.com> <86mvb2p32v.fsf@gmail.com> <A24429AE-11F0-41CB-BCBB-A6864C891026@arm.com> <79E51549-1B65-4DA8-891A-17EF061E03A3@arm.com> <861sqx300d.fsf@gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
> On 6 Jun 2017, at 11:04, Yao Qi <qiyaoltc@gmail.com> wrote:
>
> Alan Hayward <Alan.Hayward@arm.com> writes:
>
>> Tested on a --enable-targets=all and --enable-libsanitizer build using
>
> Beside --enable-targets=all, do you configure with --enable-64-bit-bfd?
>
Yes.
> Why do you configure with --enable-libsanitizer? It is a top-level
> configure option which enables to build libsanitizer. What we need here
> is to build GDB with ASAN like this,
>
> $ make CXXFLAGS='-fsanitize=address' gdb
>
> and run gdb.gdb/unittest.exp.
Sorry, my mistake.
I’ve rebuild using the above, and unittest.exp passes.
This also applies to my other 3 patches I’ve posted. My git log includes
all of those patches.
>
>>
>>
>> diff --git a/gdb/ia64-tdep.c b/gdb/ia64-tdep.c
>> index 7282acb20ac2c25e7f2c48fec3106300c385679f..d396fb81a62b0c2522900fd9cb0980aa2a5fb767 100644
>> --- a/gdb/ia64-tdep.c
>> +++ b/gdb/ia64-tdep.c
>> @@ -125,6 +125,9 @@ static CORE_ADDR ia64_find_global_pointer (struct gdbarch *gdbarch,
>>
>> #define NUM_IA64_RAW_REGS 462
>>
>> +/* Big enough to hold a FP register in bytes. */
>> +#define IA64_FP_REGISTER_SIZE 16
>
> Nit, we can replace one magic number 128 with this macro in ia64_ext_type,
>
> if (!tdep->ia64_ext_type)
> tdep->ia64_ext_type
> = arch_float_type (gdbarch, 128, "builtin_type_ia64_ext",
> floatformats_ia64_ext);
I’m not sure about this. Other files in gdb use things like
gdbarch_long_double_bit (gdbarch) instead of 128, which sounds a better solution.
Therefore, I’ve left it as it is for now.
>
> Patch is OK if there is no fail in gdb.gdb/unittest.exp.
>
Committed as originally posted.
Alan.