This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 6/11] Add ALPHA_MAX_REGISTER_SIZE
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Tue, 6 Jun 2017 14:47:44 +0000
- Subject: Re: [PATCH 6/11] Add ALPHA_MAX_REGISTER_SIZE
- Authentication-results: sourceware.org; auth=none
- Authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <772F5764-0F2A-4F53-BC41-C36AF15BED21@arm.com> <86bms3wbh5.fsf@gmail.com> <EED29198-B67C-4BD6-B4A8-12D75CD7A11B@arm.com> <D67714E2-1EDC-4CBF-9C79-964140C47671@arm.com> <86tw3t1ag0.fsf@gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
> On 6 Jun 2017, at 15:02, Yao Qi <qiyaoltc@gmail.com> wrote:
>
> Alan Hayward <Alan.Hayward@arm.com> writes:
>
>> I don't have a ALPHA machine to test on.
>> Tested on a --enable-targets=all and --enable-libsanitizer build using
>> make check with board files unix and native-gdbserver.
>
> Could you build GDB with option -fsanitize=address
> (make CXXFLAGS='-fsanitize=address') and run gdb.gdb/unittest.exp?
>
>>
>> Ok to commit?
>>
>
> OK if there is no fail in unit tests.
Tested along with the IA64 patch.
unittest.exp passes.
>
>> Alan.
>>
>> 2017-05-30 Alan Hayward <alan.hayward@arm.com>
>>
>> * alpha-tdep.c (alpha_register_to_value): Use get_frame_register_value.
>
> This line is too long. The line max length in ChangeLog is 74.
> https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog
Sorry, that was new to me (As far as I’m aware, gcc uses 80).
>
>> (alpha_value_to_register): Use ALPHA_REGISTER_SIZE.
>
>
Committed with newline added in changelog.
Alan.