This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6 3/4] Share fork_inferior et al with gdbserver
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 07 Jun 2017 17:01:43 -0400
- Subject: Re: [PATCH v6 3/4] Share fork_inferior et al with gdbserver
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 85D4E80474
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85D4E80474
- References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170504052954.16936-1-sergiodj@redhat.com> <20170504052954.16936-4-sergiodj@redhat.com> <0e95d746-9293-3301-15ed-84d6c4280116@redhat.com> <87poep8zdg.fsf@redhat.com> <f120b388-1979-5857-bd28-33bbaaf21399@redhat.com> <a9efc19d-fb7a-c686-b1ed-654362e55f31@redhat.com>
On Wednesday, June 07 2017, Pedro Alves wrote:
> On 06/07/2017 11:15 AM, Pedro Alves wrote:
>> On 05/31/2017 04:43 AM, Sergio Durigan Junior wrote:
>>>
>>>>>>> index 4ea7913..8aa85db 100644
>>>>>>> --- a/gdb/gdbserver/configure.ac
>>>>>>> +++ b/gdb/gdbserver/configure.ac
>>>>>>> @@ -462,7 +462,9 @@ esac],
>>>>>>>
>>>>>>> if $want_ipa ; then
>>>>>>> if $have_ipa ; then
>>>>>>> - IPA_DEPFILES="$ipa_obj"
>>>>>>> + # Needed because safe_strerror's definition is host-dependent
>>>>>
>>>>> Why do we end up needing safe_strerror in the IPA in the first place?
>>> This is needed because I moved the definition of
>>> trace_start_error_with_name from the old gdb/fork-child.c to
>>> common/common-utils.c. This function which uses safe_strerror, and
>>> common/common-utils.c is compiled by IPA.
>>>
>>> An option would be to keep these trace_start_error.* functions in
>>> nat/fork-inferior.c, but I think it is more logical to keep them on
>>> common-utils.c.
>>
>> I'd rather not add them to the IPA. The least unnecessary code
>> is included in that library the better, because it is injected
>> into the target process. So keeping them in fork-inferior.c
>> sounds better.
>>
>
> I tried it against v7, and that works. The think to keep
> in mind is that these trace_start_error functions
> are only called from the fork child, so they're very much
> fork-inferior.c related.
They're actually being used by some -nat.c files on gdb/, and -low.c
files on gdbserver. But as I said, I'm OK with your suggestion.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/