This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v7 1/4] gdb: Add OpenRISC or1k and or1knd target support
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Stafford Horne <shorne at gmail dot com>
- Cc: GDB patches <gdb-patches at sourceware dot org>, Openrisc <openrisc at lists dot librecores dot org>, Franck Jullien <franck dot jullien at gmail dot com>
- Date: Fri, 09 Jun 2017 11:10:37 +0100
- Subject: Re: [PATCH v7 1/4] gdb: Add OpenRISC or1k and or1knd target support
- Authentication-results: sourceware.org; auth=none
- References: <cover.1496068645.git.shorne@gmail.com> <cover.1496068645.git.shorne@gmail.com> <0d86778997b5aebf1301f883ef30833823a7dbd7.1496068645.git.shorne@gmail.com>
Stafford Horne <shorne@gmail.com> writes:
> diff --git a/gdb/features/or1k.xml b/gdb/features/or1k.xml
> new file mode 100644
> index 0000000..c138a02
> --- /dev/null
> +++ b/gdb/features/or1k.xml
> @@ -0,0 +1,12 @@
> +<?xml version="1.0"?>
> +<!-- Copyright (C) 2016 Free Software Foundation, Inc.
2017.
> +
> + set_gdbarch_print_insn (gdbarch, print_insn_or1k);
> +
Don't need to set gdbarch_print_insn, so remove this line. GDB will use
the default one, which selects the right disassembler in opcodes.
Otherwise, patch is good to me.
--
Yao (齐尧)