This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 00/19] Various DWARF piece fixes
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org, qiyaoltc at gmail dot com
- Date: Mon, 12 Jun 2017 13:38:26 +0200
- Subject: Re: [PATCH v2 00/19] Various DWARF piece fixes
- Authentication-results: sourceware.org; auth=none
- References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <8694ad33433a8f7018b98e8d9eb8e574@polymtl.ca> <m3tw41ksu8.fsf@oc1027705133.ibm.com>
On Wed, May 31 2017, Andreas Arnez wrote:
> On Tue, May 30 2017, Simon Marchi wrote:
>
>> I went over the patches that Yao hasn't replied on, namely 13, 14, 16, 17
>> and 19, it all looks good to me (note the little comment on #17). Since
>> it's some tricky code, I wasn't always able to convince myself of the
>> correctness by just looking at it. But I went through the test cases by
>> hand, when applicable, and it gives me enough confidence that the code is
>> correct (or at least more correct than the current code :)).
>
> Thanks a lot for looking at this!
>
>> I'm not sure I like the merge of the two functions, already scary by
>> themselves, in one scarier monster, but I understand the downsides of
>> having two separate functions, so I'm ok to go with it.
>
> Yeah, it's a trade-off.
>
>> I'll let Yao decide if he wants to go himself through the remaining
>> patches.
>
> OK, I guess I'll wait a few more days for further feedback from Yao (or
> others).
OK, I've waited a few days by now... Is this ready to push?
https://sourceware.org/ml/gdb-patches/2017-05/msg00215.html
--
Andreas