This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] xtensa: Properly strdup string when building reggroup

From: Stafford Horne <shorne at gmail dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Yao Qi <qiyaoltc at gmail dot com>, GDB patches <gdb-patches at sourceware dot org>
Date: Tue, 13 Jun 2017 19:06:24 +0900
Subject: Re: [PATCH] xtensa: Properly strdup string when building reggroup
Authentication-results: sourceware.org; auth=none
References: <20170610133422.19913-1-shorne@gmail.com> <86poe9aa4y.fsf@gmail.com> <590b6ff49c8bc167ca2e179ec14818b0@polymtl.ca>

On Mon, Jun 12, 2017 at 10:38:09AM +0200, Simon Marchi wrote:
> On 2017-06-12 10:22, Yao Qi wrote:
> > This exposes another bug, IMO, here,
> > 
> >   for (i = 0; i < XTENSA_MAX_COPROCESSOR; i++)
> >     {
> >       cpname[2] = '0' + i;
> >       xtensa_cp[i] = reggroup_new (cpname, USER_REGGROUP);
> >     }
> > 
> > and XTENSA_MAX_COPROCESSOR is 0x10, so we can see "cp:", "cp;", which
> > looks odd.
> 
> Heh, looks like the patch here
> 
>   https://sourceware.org/ml/gdb-patches/2011-03/msg00571.html
> 
> did not take that into account :)

Right, I might was well resend the patch with an sprintf().

-Stafford

References:
- [PATCH] xtensa: Properly strdup string when building reggroup
  - From: Stafford Horne
- Re: [PATCH] xtensa: Properly strdup string when building reggroup
  - From: Yao Qi
- Re: [PATCH] xtensa: Properly strdup string when building reggroup
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]