This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix register selection in var-access.exp
On Tue, Jun 13 2017, Pedro Alves wrote:
> On 06/13/2017 09:33 PM, Simon Marchi wrote:
>
>> However could you (or somebody else) explain this to me? The doc of
>> is_amd64_regs_target says:
>>
>> 2465 # Return 1 if target has x86_64 registers - either amd64 or x32.
>> 2466 # x32 target identifies as x86_64-*-linux*, therefore it cannot be
>> determined
>> 2467 # just from the target string.
>>
>> If x32 identifies as x86_64-something and that procedure should return
>> true when testing with x32 and x86_64/amd64, why can't we test the
>> target string for x86_64-*?
>
> Some vendors build --target i686-* toolchains, and then
> use -m64 to target the 64-bit multilib.
Hm, I wasn't aware of that. In addition, even on an x86_64-* target,
-m32 could be in effect. IMHO the comment is indeed misleading, but I'd
rather leave it to someone who actually knows all the various x86/amd64
targets and ABIs to fix it.
As this discussion is unrelated to the fix itself and the fix was
approved already, I pushed it now.
Thanks,
Andreas