This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v6] C++ify gdb/common/environ.c

On 06/19/2017 07:23 PM, Sergio Durigan Junior wrote:
> On Monday, June 19 2017, Pedro Alves wrote:

>> Missed fixing move ctor?
>>
>> +  /* Move constructor.  */
>> +  gdb_environ (gdb_environ &&e)
>> +    : m_environ_vector (std::move (e.m_environ_vector))
>> +  {}
> 
> Indeed.  Fixed now.  I'll submit v7.

Make sure to add unit tests for the move ctor.  E.g., reuse
the move assign tests.

Thanks,
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]