This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Unset PROMPT_COMMAND before testing
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 22 Jun 2017 11:12:02 +0100
- Subject: Re: [PATCH] gdb: Unset PROMPT_COMMAND before testing
- Authentication-results: sourceware.org; auth=none
- References: <20170616231210.14867-1-andrew.burgess@embecosm.com>
Andrew Burgess <andrew.burgess@embecosm.com> writes:
> One of the GDB tests starts up a sub-shell and runs a few commands in
> it. In some cases, a users PROMPT_COMMAND might not work in the
> sub-shell GDB starts, which could cause the shell to emit unexpected
> warnings or errors, this in turn could cause tests to fail.
What is the concrete output in your case?
>
> The current example is gdb.base/batch-preserve-term-settings.exp, but
> there could be others in the future.
>
> I don't see any regressions with this patch, but I do now see 5
> additional passes on gdb.base/batch-preserve-term-settings.exp.
This patch sets the env for build rather than host, so it doesn't help
in remote host. Note that I don't think DejaGNU can set env in remote.
--
Yao (齐尧)