Re: [PATCH 2/2] gdb: Make some test names unique

[Yao Qi <qiyaoltc at gmail dot com>]

On Thu, Jun 22, 2017 at 12:08 PM, Pedro Alves <palves@redhat.com> wrote:
> On 06/22/2017 11:37 AM, Yao Qi wrote:
>> Andrew Burgess <andrew.burgess@embecosm.com> writes:
>>
>>
>>>  mi_gdb_test "540-data-evaluate-expression vla1(1)" \
>>> -  "540\\^done,value=\"1\"" "evaluate filled vla"
>>> +  "540\\^done,value=\"1\"" "evaluate filled vla(1)"
>>
>> Do not use "tail parentheses" on the test message,
>> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages
>
> The wiki doesn't mention it, but I think the rule should only apply when
> there's a space before the parens.

I wanted to get confirm from analyze-racy-logs.py,
but I was lost in it, so I decided to follow the wiki.

Andrew,
your patch is OK as-is.

>
> I don't think it's worth it, or even a good idea to try to
> come up with different test names for all of these.  In cases like
> these, I think it's generally possible to avoid the space before
> the parens.  So IMO, we should clarify the rule instead
> (and the buildbot testresult diffing accordingly, if necessary).
>

The current rule is "When you write a test, do not
put text between parentheses at the end of the text
message", we can change it "when you write a test,
do not put text between parentheses at the end of
the text message and space before parentheses".

They are OK,
PASS: gdb.base/foo.exp: whatever test
FAIL: gdb.base/foo.exp: whatever test (timeout)
PASS: gdb.base/foo.exp: whatever test(1st)
PASS: gdb.base/foo.exp: whatever test(2nd)

They are not OK,
PASS: gdb.trace/trace-break.exp: 2 trace trace on: trace set_point (1)
PASS: gdb.trace/trace-break.exp: 2 trace trace on: trace set_point (2)

Is it right?

-- 
Yao (齐尧)