This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] gdb: Make some test names unique
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Thu, 22 Jun 2017 13:12:36 +0100
- Subject: Re: [PATCH 2/2] gdb: Make some test names unique
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 08574BBF4A
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 08574BBF4A
- References: <cover.1497466455.git.andrew.burgess@embecosm.com> <c9b6ef063fbb5e33c157b1041418cd2fb7d8cf27.1497466455.git.andrew.burgess@embecosm.com>
On 06/14/2017 07:57 PM, Andrew Burgess wrote:
> @@ -95,7 +95,7 @@ mi_run_cmd
> mi_expect_stop "breakpoint-hit" "vla" "" ".*vla.f90" "$bp_lineno" \
> { "" "disp=\"del\"" } "run to breakpoint at line $bp_lineno"
> mi_gdb_test "520-data-evaluate-expression vla1" \
> - "520\\^done,value=\"\\(1, 1, 1, 1, 1\\)\"" "evaluate filled vla"
> + "520\\^done,value=\"\\(1, 1, 1, 1, 1\\)\"" "evaluate filled vla at line $bp_lineno"
>
As principle, please avoid putting line numbers in test names. This
causes test names to spuriously change if/when the source file changes.
Thanks,
Pedro Alves