On 06/26/2017 01:28 PM, Simon Marchi wrote:
I wanted to keep it simple and easy to understand, so I didn't want to
add to many layers of definitions. I thought that even if we ignored
-Wunused-function in the vector macro expansions when compiling with
GCC, it wasn't a big deal.
That's another option (and I think it should be fine, with a comment),
but it wasn't what the patch was doing, so you'd be leaving deciding
whether that's fine to whoever comes next and wants to make
DIAGNOSTICS_IGNORE_UNUSED_FUNCTION on gcc. IMO, that's a form of
technical dept that we should avoid.