This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] vec: Silence -Wunused-function warnings on clang


On 2017-06-26 14:47, Pedro Alves wrote:
On 06/26/2017 01:28 PM, Simon Marchi wrote:

I wanted to keep it simple and easy to understand, so I didn't want to
add to many layers of definitions.  I thought that even if we ignored
-Wunused-function in the vector macro expansions when compiling with
GCC, it wasn't a big deal.

That's another option (and I think it should be fine, with a comment),
but it wasn't what the patch was doing, so you'd be leaving deciding
whether that's fine to whoever comes next and wants to make
DIAGNOSTICS_IGNORE_UNUSED_FUNCTION on gcc.  IMO, that's a form of
technical dept that we should avoid.

You are right, and it was due to technical laziness :P.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]