This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 08/40] completion_list_add_name wrapper functions

From: Yao Qi <qiyaoltc at gmail dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 27 Jun 2017 13:56:17 +0100
Subject: Re: [PATCH 08/40] completion_list_add_name wrapper functions
Authentication-results: sourceware.org; auth=none
References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-9-git-send-email-palves@redhat.com>

Pedro Alves <palves@redhat.com> writes:

> I've had to adjust these macros numerous times while working on this
> series, adding/removing parameters while experimenting with designs.
> At some point, I got fed up with fighting the preprocessor, and
> decided to make them proper functions.
>
> gdb/ChangeLog:
> yyyy-mm-dd  Pedro Alves  <palves@redhat.com>
>
> 	* symtab.c (COMPLETION_LIST_ADD_SYMBOL)
> 	(MCOMPLETION_LIST_ADD_SYMBOL): Delete macros, replace with ...
> 	(completion_list_add_symbol, completion_list_add_msymbol):
> 	... these new functions.
> 	(add_symtab_completions)
> 	(default_make_symbol_completion_list_break_on_1): Adjust.

It is obvious.  Patch is good to me.

-- 
Yao (齐尧)

Follow-Ups:
- Re: [PATCH 08/40] completion_list_add_name wrapper functions
  - From: Pedro Alves

References:
- [PATCH 00/40] C++ debugging improvements: breakpoints, TAB completion, more
  - From: Pedro Alves
- [PATCH 08/40] completion_list_add_name wrapper functions
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]