This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 04/10] Remove EXT_LANG_BT_COMPLETED
- From: Pedro Alves <palves at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>, Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 27 Jun 2017 17:40:54 +0100
- Subject: Re: [RFA 04/10] Remove EXT_LANG_BT_COMPLETED
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 44185C054C5A
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 44185C054C5A
- References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-5-tom@tromey.com> <2cc665c2-ea5b-efd3-deac-f2fc61e1feeb@redhat.com>
On 04/28/2017 03:52 PM, Phil Muldoon wrote:
> On 25/04/17 20:41, Tom Tromey wrote:
>> While looking at the frame filter code, I noticed that
>> EXT_LANG_BT_COMPLETED is not really needed. Semantically there is no
>> difference between the "completed" and "ok" results. So, this patch
>> removes this constant.
>>
>> ChangeLog
>> 2017-04-25 Tom Tromey <tom@tromey.com>
>>
>> * python/py-framefilter.c (py_print_frame): Return
>> EXT_LANG_BT_OK.
>> (gdbpy_apply_frame_filter): Update comment.
>> * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
>> Remove.
>> <EXT_LANG_BT_NO_FILTERS>: Change value.
>
> I wish I could remember why I added this. OTOH it could have been a relic even from the initial code submission.
>
> Anyway, patch LGTM.
LGTM too.
Thanks,
Pedro Alves