This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 08/10] Move some code later in backtrace_command_1


On 04/25/2017 08:41 PM, Tom Tromey wrote:
> PR backtrace/15584 notes that some code in backtrace_command_1 is not
> useful when frame filters are in use.  

Doesn't the "info verbose on" bit affect frame filters too?
Particularly the:

"Need to do this in a
 separate pass so that "Reading in symbols for xxx" messages
 don't screw up the appearance of the backtrace."

... remark.

Not sure I fully understand whether that "info verbose" code
makes sense nowadays, though.  It doesn't seem to be documented
in the manual.

In any case, if you need that, then I guess it'd be done
somewhere inside the frame filters code, I suppose?

With that in mind, this LGTM.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]