This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 00/25 V2] Make GDB builtin target descriptions more flexible
"Tedeschi, Walfred" <walfred.tedeschi@intel.com> writes:
> Hello Yao,
>
> I did some tests and they are looking fine for remote and native gdb.
> I could tweak the XCR0 in GDB and GDBSERVER and see tests that also use cpu-id to detect features failing, as expected! Very nice!
> Thanks again!
Hi Walfred,
Thanks for playing with these patches, and good to hear that you like it :)
>
> As an observation, in the gdbserver side there are calls to _get_ipa_tdesc. I suppose we could rename this to a more generic name.
> About the design: GDBserver still uses the combination of cpu features to build the target description.
> On the other hand, the
> improvement was huge, i.e. I would go to accept the patch and consider
> an additional patch series to address gdbserver tdesc creation.
I would like GDBserver creates target description in the same way as GDB
does, and then share the code creating target descriptions between GDB
and GDBserver. It was mentioned in the bottom of cover letter, "share
more code on creating x86-linux target descriptions in GDB and
GDBserver" in next step.
--
Yao (齐尧)