This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Import setenv and unsetenv from gnulib
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Anton Kolesov <Anton dot Kolesov at synopsys dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Francois Bedard <Francois dot Bedard at synopsys dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Tue, 4 Jul 2017 11:20:12 +0100
- Subject: Re: [PATCH] Import setenv and unsetenv from gnulib
- Authentication-results: sourceware.org; auth=none
- References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com>
On Mon, Jul 3, 2017 at 5:27 PM, Anton Kolesov
<Anton.Kolesov@synopsys.com> wrote:
> This patch supersedes
> https://sourceware.org/ml/gdb-patches/2017-07/msg00009.html
>
> ---
>
> Patch [1] broke a build on MinGW hosts, because MinGW doesn't provide POSIX
> functions setenv () and unsetenv (). This can be fixed by using
> implementations from gnulib.
>
> [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9a6c7d9c0
>
We need commit hash and subject only, like
9a6c7d9c0 (C++ify gdb/common/environ.c)
Did you run regression test on x86-linux? If there
is no regression, patches is good to me.
--
Yao (齐尧)