This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Import setenv and unsetenv from gnulib

Anton Kolesov <Anton.Kolesov@synopsys.com> writes:

> If I run "make check-gdb", I don't see any obvious new errors from this patch.
> Unfortunately results are a little bit volatile - some tests
> sporadically fail even
> if I run them with same GDB build and sources, even without this patch
> - I've run
> testsuite five times and got five similar, but different results.
>

They are not regressions to me.

> Selftests pass on x86_64-linux. On Windows with this patch there is a failure in
> iconv sefltest, which seems unrelated (was present even when I've tried to use
> putenv directly instead of importing gnulib module). 

Thanks for running tests on Windows.  Your patch is safe to go in.
Please push it in.

-- 
Yao (齐尧)
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]