This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 10/40] Clean up "completer_handle_brkchars" callback handling
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 13 Jul 2017 14:08:21 -0700
- Subject: Re: [PATCH 10/40] Clean up "completer_handle_brkchars" callback handling
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=keiths at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 425A180480
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 425A180480
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-11-git-send-email-palves@redhat.com>
On 06/02/2017 05:22 AM, Pedro Alves wrote:
> This patch cleans up "completer_handle_brkchars" callback handling:
>
> - Renames the function typedef to better match its intent:
> completer_ftype_void -> completer_handle_brkchars_ftype
>
> - Factors out common code in complete_line_internal handling the
> "handle_brkchars" callback to a separate function.
>
> - Centralizes all the "completer method" to "handle_brkchars method"
> mapping in a single function.
>
I don't see any issues.
Keith