This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 18/40] A smarter linespec completer
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Mon, 17 Jul 2017 12:02:16 -0700
- Subject: Re: [PATCH 18/40] A smarter linespec completer
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=keiths at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7E204356E4
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7E204356E4
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-19-git-send-email-palves@redhat.com> <59695CC2.2090206@redhat.com> <f1742157-4c16-3d07-ed61-4d4c1358b3a3@redhat.com>
On 07/17/2017 11:21 AM, Pedro Alves wrote:
>>
>>> + int completion_quote_char;
>>
>> Why int?
>
> Mainly because the related readline code uses int too.
Well, that's definitely a good reason! That's all I really wanted to know.
> I can make this a char, and for consistency try to make completer_tracker
> use char too, though I'd prefer to do that as a patch on top of this one
> that touches every path in a single go, than update the few related
> completer_tracker patches, mainly because gdb_rl_find_completion_word
> is already in master. Would you mind that?
It's up to you, really. IMO, I don't see any overwhelming reason to change this. In fact, a good case could be made for not changing it (now that I know what said reason is).
> Here are the comments that I came up with. WDYT?
Perfect! Thanks!
Keith