This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 22/40] get_int_var_value
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 20 Jul 2017 18:15:00 +0100
- Subject: Re: [PATCH 22/40] get_int_var_value
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0489C8B962
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0489C8B962
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-23-git-send-email-palves@redhat.com> <596D35F6.3010801@redhat.com>
On 07/17/2017 11:11 PM, Keith Seitz wrote:
> On 06/02/2017 05:22 AM, Pedro Alves wrote:
>> I noticed that get_int_var_value's parameters could use some
>> constification. And then realized that client code would become
>> simpler by changing the interface to return the success/failure
>> indication as actual return value, as allows getting rid of the the
>> local "boolean" variable.
>
> It is certainly more appropriate for Joel to comment, but I did look through the patch, and it is a pretty straightforward change. I didn't notice any issues.
Thanks! I want ahead and push it in to get it out of
the way of the following, more interesting patches. I'll of
course gladly address any concern that Joel may have.
Thanks,
Pedro Alves