This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Ruslan Kabatsayev <b7 dot 10110111 at gmail dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 27 Jul 2017 11:25:18 +0200
Subject: Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
Authentication-results: sourceware.org; auth=none
References: <1499926070-13827-1-git-send-email-b7.10110111@gmail.com> <1be450ee-ea96-76a4-dbf9-81f15b2d4234@gmail.com> <7ee96675bc6f2307642fb638a9b65839@polymtl.ca> <CAHEcG95onBPe2QpWseG4GH22eXQxfYz6QnTd_dFnO1XX-Lz0AQ@mail.gmail.com> <b25ba2b4e0945631b951d8a8611bb9c7@polymtl.ca> <CAHEcG94_2ePexhF1bne5awadQ10LuvJ4seJ0Tz6LW7kss+7Chw@mail.gmail.com>

On 2017-07-27 11:11, Ruslan Kabatsayev wrote:

I was thinking that perhaps that when focusing...

a source view: s/n do source line stepping, S/N do assembly stepping
an asm view: s/n do assembly stepping, S/N do source line stepping

Basically, they would switch role.  Is that too confusing?

This might be OK, but what if current focus in on registers window?
Disable all single-key stepping?

Indeed. And when the user is in the "Source + Asm + Prompt"configuration and the prompt is focused, what would we do? That'sperhaps a good idea in theory, but it would need to be more thoughtthrough.

You patch provides a predictable behavior across all modes, so I don'tthink we can go wrong with that.


Simon

References:
- [PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
  - From: Ruslan Kabatsayev
- [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
  - From: Ruslan Kabatsayev
- Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
  - From: Simon Marchi
- Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
  - From: Ruslan Kabatsayev
- Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
  - From: Simon Marchi
- Re: [PING][PATCH] Add shortcuts for "nexti" and "stepi" commands in Single-Key mode
  - From: Ruslan Kabatsayev

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]