This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] mem-break: Fix breakpoint insertion location
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: "Maciej W. Rozycki" <macro at imgtec dot com>
- Cc: <gdb-patches at sourceware dot org>, Yao Qi <yao dot qi at linaro dot org>, Joel Brobecker <brobecker at adacore dot com>
- Date: Fri, 04 Aug 2017 14:24:29 +0100
- Subject: Re: [PATCH] mem-break: Fix breakpoint insertion location
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.00.1708011707230.29991@tp.orcam.me.uk>
"Maciej W. Rozycki" <macro@imgtec.com> writes:
> Fix a commit cd6c3b4ffc4e ("New gdbarch methods breakpoint_kind_from_pc
> and sw_breakpoint_from_kind") regression and restore the use of
> ->placed_size rather than ->reqstd_address as the location for a memory
s/placed_size/placed_address/
The patch looks good to me, but please give me two or three days to run
the tests on an armv7 board. The board is being used for other tests,
and I'll start the regression test on Monday next week.
--
Yao (齐尧)