This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 29/40] Simplify completion_list_add_name | remove sym_text / sym_text_len
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 8 Aug 2017 13:59:19 -0700
- Subject: Re: [PATCH 29/40] Simplify completion_list_add_name | remove sym_text / sym_text_len
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 25D51883C7
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-30-git-send-email-palves@redhat.com>
On 06/02/2017 05:22 AM, Pedro Alves wrote:
>
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * ada-lang.c (ada_make_symbol_completion_list): Remove text and
> text_len locals and don't pass them down.
> * symtab.c (completion_list_add_name): Remove
> sym_text/sym_text_len parameters and adjust.
> (completion_list_add_symbol, completion_list_add_msymbol)
> (completion_list_objc_symbol, completion_list_add_fields)
> (add_symtab_completions): Likewise.
> (default_collect_symbol_completion_matches_break_on)
> (collect_file_symbol_completion_matches): Remove sym_text_len
> local and don't pass it down.
> * symtab.h (completion_list_add_name): Remove
> sym_text/sym_text_len parameters.
LGTM
Keith