This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] Unbreak gdb build on 32-bit host with ADI support
- From: Pedro Alves <palves at redhat dot com>
- To: Weimin Pan <weimin dot pan at oracle dot com>, gdb-patches at sourceware dot org
- Date: Thu, 31 Aug 2017 10:31:08 +0200
- Subject: Re: [PATCH v3] Unbreak gdb build on 32-bit host with ADI support
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DCD3410C496
- References: <1503707605-65627-1-git-send-email-weimin.pan@oracle.com>
Hi Weimin,
> +2017-08-25 Weimin Pan <weimin.pan@oracle.com>
> +
> + * sparc64-tdep.c: Unbreak gdb build on 32-bit host with ADI support.
> +
In the GNU ChangeLog format, this should say which functions were touched,
and what was changed, as opposed to "why" things were changed. Please take a
look here to learn more about this:
https://sourceware.org/gdb/wiki/ContributionChecklist
You actually already had the right info in the commit log, so I cooked up
an entry for you, and pushed the patch in with that:
2017-08-31 Weimin Pan <weimin.pan@oracle.com>
* sparc64-tdep.c (adi_stat_t): Fix comment formatting.
(adi_available): Use a temp variable of type CORE_ADDR as argument
3 when calling target_auxv_search.
(adi_normalize_address): Use masks and xor operators to calculate
normalized address.
(adi_read_versions, adi_write_versions, adi_print_versions)
(do_examine, do_assign): Use paddress.
Thanks for the patch.
Pedro Alves