This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Issue complaint instead of assert for invalid/unhandled DW_AT_accessibility
- From: Keith Seitz <keiths at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 17 Oct 2017 14:38:32 -0700
- Subject: [PATCH] Issue complaint instead of assert for invalid/unhandled DW_AT_accessibility
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DE62BFED0
- References: <9431dc9a-2156-10d7-8fbd-b46d5af9a72f@redhat.com>
A previous patch called gdb_assert_not_reached whenever reading
the accessibility of a nested typedef definition. Wisely, Pedro has asked me
not do this.
This patch changes the previous one so that it issues a complaint instead.
gdb/ChangeLog:
* dwarf2read.c (dwarf2_add_typedef): Issue a complaint on unhandled
DW_AT_accessibility.
---
gdb/ChangeLog | 5 +++++
gdb/dwarf2read.c | 3 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e16b048..4afd897 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-10-17 Keith Seitz <keiths@redhat.com>
+
+ * dwarf2read.c (dwarf2_add_typedef): Issue a complaint on unhandled
+ DW_AT_accessibility.
+
2017-10-17 Tom Tromey <tom@tromey.com>
* disasm.c (do_mixed_source_and_assembly_deprecated): Use
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index f27d9b9..686fa3f 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -13131,7 +13131,8 @@ dwarf2_add_typedef (struct field_info *fip, struct die_info *die,
fp->is_protected = 1;
break;
default:
- gdb_assert_not_reached ("unexpected accessibility attribute");
+ complaint (&symfile_complaints,
+ _("Unhandled DW_AT_accessibility value (%x)"), accessibility);
}
new_field->next = fip->typedef_field_list;
--
2.1.0