This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 04/13] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Fri, 03 Nov 2017 10:37:27 -0600
Subject: Re: [RFA 04/13] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink
Authentication-results: sourceware.org; auth=none
References: <20171102223612.3642-1-tom@tromey.com> <20171102223612.3642-5-tom@tromey.com> <f0582e8769c5b56cf3f6a47a6e74a873@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Just one tiny nit: when possible, I like to replace strcmp with
Simon> std::string's operator==
Simon>   if (dir == symlink_dir.get ())
Simon> but I'll leave it up to you.

Good idea, I made this change; though I think it should be != due to:

> +	      if (strcmp (dir.c_str (), symlink_dir.get ()) != 0)

Tom

References:
- [RFA 00/13] more cleanup removal
  - From: Tom Tromey
- [RFA 04/13] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink
  - From: Tom Tromey
- Re: [RFA 04/13] Use unique_xmalloc_ptr in find_separate_debug_file_by_debuglink
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]