This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/4] Use flexible target descriptors for aarch64


> On 23 Nov 2017, at 17:50, Yao Qi <qiyaoltc@gmail.com> wrote:
> 
> On 17-11-23 16:19:44, Alan Hayward wrote:
>> 
>> Files regenerated in patch below:
> 
> Commit log is the part to be reviewed in the patch review.  It is
> better to post the patch together with the commit log, although the
> commit log may not be changed.
> 
>> 
>> 
>> diff --git a/gdb/arch/aarch64.c b/gdb/arch/aarch64.c
>> index 95d9906f10e660fda99d73a0d2a9d184fd3a7b52..59f9330235e639d44920cab79b595e5266a935ff 100644
>> --- a/gdb/arch/aarch64.c
>> +++ b/gdb/arch/aarch64.c
>> @@ -17,14 +17,27 @@
>> 
>> 
>> #include "aarch64.h"
>> +#include <stdlib.h>
>> +#include <string.h>
>> 
> 
> Is it necessary to include string.h?  Otherwise, patch is good to me.
> 

Removed sting.h (I was sure I had a strcmp in here)
All 4 Patches pushed.

Alan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]