Re: [PATCH] Define HAVE_NATIVE_GCORE_HOST on NetBSD

[Kamil Rytarowski <n54 at gmx dot com>]

On 24.11.2017 22:44, Ulrich Weigand wrote:
> Joel Brobecker wrote:
>>
>>> NetBSD ships with gcore(1) againg since the version 2.0.
>>> This tool is functional and actively maintained.
>>>
>>> gdb/ChangeLog
>>> 2017-09-05  Kamil Rytarowski  <n54@gmx.com>
>>>
>>> 	* configure.nat:  Define HAVE_NATIVE_GCORE_HOST on NetBSD.
>>
>> Makes sense. Approved.
> 
> This doesn't look right to me.  Note that HAVE_NATIVE_GCORE_HOST
> is not at all about whether there is some external gcore tool
> provided by the OS.  Rather, this flag defines whether the GDB
> build should *provide* a gcore tool; if true, the GDB install
> process provides a simple shell script called gcore that calls
> GDB and runs the gcore command.
> 
> This only makes sense on platforms where GDB supports the gcore
> command in the first place.  This is not the case for GDB on
> NetBSD as far as I can tell; the NetBSD native files do not
> define any of the required callbacks.
> 
> What was the reason to add this define?
> 
> Bye,
> Ulrich
> 

This option was misleading and I assumed that it's about gcore(1) being
available on the host system. It happened to be different, but I will
add in future proper support anyway so it can stay as it is.

Attachment: signature.asc
Description: OpenPGP digital signature