This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 1/3] Handle custom completion match prefix / LCD

From: Keith Seitz <keiths at redhat dot com>
To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
Date: Mon, 27 Nov 2017 17:42:54 -0800
Subject: Re: [PATCH v2 1/3] Handle custom completion match prefix / LCD
Authentication-results: sourceware.org; auth=none
References: <1511802824-643-1-git-send-email-palves@redhat.com> <1511802824-643-2-git-send-email-palves@redhat.com>

On 11/27/2017 09:13 AM, Pedro Alves wrote:
> In v2:
> 
>   - Addresses Keith's review.  The main change is that it adds a
>     convenience method to completion_match_result to set both regular
>     match and the match for LCD.  This is the new
>     completion_match_result::set_match method.

That looks okay to me.

Thanks!

Keith

References:
- [PATCH v2 0/3] C++ debugging improvements: wild matching and ABI tags
  - From: Pedro Alves
- [PATCH v2 1/3] Handle custom completion match prefix / LCD
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]