This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA v2 2/2] Update usage text for load, symbol-file


LGTM, but...

On 11/25/2017 08:35 PM, Tom Tromey wrote:
> This updates the usage text for the load and symbol-file commands.
> 

... I was surprised add-symbol-file wasn't getting the READNOW_HELP
treatment too, but actually I think it is:

> @@ -3890,7 +3896,8 @@ Usage: add-symbol-file FILE ADDR [-readnow | -s SECT-NAME SECT-ADDR]...\n\
>  ADDR is the starting address of the file's text.\n\
>  Each '-s' argument provides a section name and address, and\n\
>  should be specified if the data and bss segments are not contiguous\n\
> -with the text.  SECT-NAME is a section name to be loaded at SECT-ADDR."),
> +with the text.  SECT-NAME is a section name to be loaded at SECT-ADDR.\n"
> +READNOW_HELP),
>  	       &cmdlist);
>    set_cmd_completer (c, filename_completer);

here.

> ChangeLog
> 2017-11-25  Tom Tromey  <tom@tromey.com>
> 
> 	* symfile.c (_initialize_symfile): Update usage text for
> 	symbol-file, load.

Ditto, please mention add-symbol-file.  Also, $subject.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]