This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 5/6] Change Ada exceptions to use std::string
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 1 Dec 2017 07:10:35 -0500
- Subject: Re: [RFA 5/6] Change Ada exceptions to use std::string
- Authentication-results: sourceware.org; auth=none
- References: <20171130030140.14830-1-tom@tromey.com> <20171130030140.14830-6-tom@tromey.com> <20171130220348.cqv3ik5c2lie7xm5@adacore.com> <20171130225916.csgxhw2gcauyby6x@adacore.com> <874lpbuxvu.fsf@tromey.com>
> Joel> Pb #1: Crash while trying to insert an assert catchpoint:
>
> I wonder why I didn't see any problems from the buildbot.
>
> Joel> Pb #3: condition handling in exception catchpoints is broken
>
> Joel> Tom removed a call to "skip_spaces" before checking for the next
> Joel> argument, and I am not sure I understand why.
>
> Here I was confused and thought extract_arg skipped spaces again after
> extracting the arg. But, it doesn't.
>
> Still - why not test failures? This is disturbing.
That's indeed strange. Do we have access to the reference report?
Maybe the Ada testing is not run (eg: missing Ada compiler on
the buildbot), or maybe the Ada compiler there is such that the tests
were failing in the first place, preventing it from detecting
regressions?
In any case, I'm quite happy to be the safety net in this case...
--
Joel