This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Clear non-significant bits of address in watchpoint
Looks good to me with formatting nits pointed out below fixed.
On 12/08/2017 10:04 AM, Yao Qi wrote:
> 2017-12-01 Yao Qi <yao.qi@linaro.org>
>
> * breakpoint.c (update_watchpoint): Call
> significant_addr.
Wrong name: significant_addr -> address_significant.
Guess you went back and forth deciding the function name. :-)
> @@ -1867,7 +1867,7 @@ update_watchpoint (struct watchpoint *b, int reparse)
> loc->gdbarch = get_type_arch (value_type (v));
>
> loc->pspace = frame_pspace;
> - loc->address = addr;
> + loc->address = address_significant (loc->gdbarch, addr);
Spurious space before '='.
Thanks,
Pedro Alves