This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v6 2/2] Implement pahole-like 'ptype /o' option


On Thursday, December 14 2017, Pedro Alves wrote:

> Something broke in v5 -> v6 in the offset and hole computation.

Thanks for catching this.

Indeed, the way the offset_bitpos is propagated has changed, and the
patch is wrongly calculating it before printing inner fields of
structs/unions.

I've fixed the logic and now the behavious is back to the old one.  All
the tests that were passing before are still passing now, which means
that I wasn't testing this specific scenario.  For that reason, I've
added one more test to cover this.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]