This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] regresssion(internal-error) printing subprogram argument
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 3 Jan 2018 08:33:45 +0400
- Subject: Re: [RFC] regresssion(internal-error) printing subprogram argument
- Authentication-results: sourceware.org; auth=none
- References: <20171213103655.msbaxfrykc36f4a7@adacore.com> <cedc827c-ecbe-4aa3-5229-beface0f8c01@redhat.com> <f5f83e6b-4ce1-7d5f-f11d-fa2979907ff2@redhat.com> <20171215094755.dwocipbcwvtdm6f6@adacore.com> <00320239-44c8-b9c3-013b-b27c771e3401@redhat.com> <07a154ef-b6f5-ad86-1410-a73620de4b5b@redhat.com>
Hi Pedro,
> > Maybe what we need is to be a little less aggressive then and
> > add a new symbol_name_match_type::SEARCH_SYMBOL instead that takes as
> > input a non-user-input search symbol like symbol_name_match_type::LITERAL
> > was, and then we skip any decoding/demangling steps (like LITERAL) and make:
> > - Ada treat that as a verbatim match,
> > - other languages treat it as symbol_name_match_type::FULL.
[...]
> With the patch below applied on top, which is a minimal version of
> the design change I suggested (LITERAL -> SEARCH_SYMBOL), I now get
> again the same "maint check-psymtabs" output that I get with system gdb.
> So seems like this is on the good track.
>
> Your internal-error test still passes as well as the new
> "maint check-psymtabs" for gdb.ada/ testcase.
Sounds like we are indeed on the right track!
I ran the changes through both the official testsuite and AdaCore's
testsuite, and I can confirm no regression :). Is there something
else I can do to help?
--
Joel