This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7)
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Andrew Pinski <pinskia at gmail dot com>
- Date: Fri, 5 Jan 2018 18:34:35 +0000
- Subject: Re: [PATCH] Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7)
- Authentication-results: sourceware.org; auth=none
- References: <1513305092-8610-1-git-send-email-palves@redhat.com>
On 12/15/2017 02:31 AM, Pedro Alves wrote:
> At https://sourceware.org/bugzilla/show_bug.cgi?id=18653#c7, Andrew
> reports that the fix for PR gdb/18653 made GDB useless if you preload
> libSegFault.so, because GDB internal-errors on startup:
>
...
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * common/signals-state-save-restore.c
> (save_original_signals_state): New parameter 'quiet'. Warn if we
> find a custom handler preinstalled, instead of internal erroring.
> But only warn if !quiet.
> * common/signals-state-save-restore.h
> (save_original_signals_state): New parameter 'quiet'.
> * main.c (captured_main_1): Move save_original_signals_state call
> after option handling, and pass QUIET.
>
> gdb/gdbserver/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * server.c (captured_main): Pass quiet=false to
> save_original_signals_state.
>
> gdb/testsuite/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * gdb.base/libsegfault.exp: New.
I've pushed this in, both master and 8.1 branch.
Thanks,
Pedro Alves